From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 23 Feb 2021 08:21:24 GMT
Subject: Re: [PATCH v3] rebase: add a config option for --no-fork-point
Message-ID: <xmqqo8gb42kb.fsf@gitster.g>
In-Reply-To: <YDSvhEBh8YeCblpa@generichostname>

Denton Liu <liu.denton@gmail.com> writes:

> I don't think this test is quite necessary. In other parts of the
> code, we've already tested that local configs have priority over
> global configs. We can assume that config machinery works so we
> don't need to test it here.

I am not so sure if we should place so much trust in the code of
"rebase", or any other subsystem for that matter, that it uses the
configuration API and parse-options API correctly.

The do_test_rebase helper introduced here would be useful clean-up
on its own, so I'd rather take it as-is.