Re: [PATCH 6/7] test-lib: make --verbose output valid TAP

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 10, 2021, 01:11 UTC
Message-ID: <xmqqo8fryfrc.fsf@gitster.c.googlers.com>
In-Reply-To: <20210309160219.13779-7-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 10 quoted lines

> Replace it with a simple method for ensuring that we have valid TAP
> both on stdout, and in any verbose output we write. When we detect
> that we're running under "prove" we prefix all legitimate TAP
> directives with "GIT_TEST_TEE_STARTED":
>
>     $ GIT_TEST_TEE_STARTED=1 ./t5547-push-quarantine.sh
>     GIT_TEST_TEE_STARTED ok 1 - create picky dest repo
>     GIT_TEST_TEE_STARTED ok 2 - accepted objects work
>     [...]
>     GIT_TEST_TEE_STARTED 1..6

Ah, OK, so these perl scripts that use Test::More think they are emitting TAP, but because the prefix is not added to any of their output, they are not considered to be a tap output at all.

So did the "external" tests lose a lot of value with this change? They used to point out individual breakage, but now it is just "passed as a whole (or not)" boolean?