Re: [PATCH 2/3] test-lib: add --verbose-log option
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 21, 2016, 17:12 UTC
- Message-ID
- <xmqq7f91d3tb.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20161021104759.hx6q7u66r3ll7l44@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> This patch implements option (5), which seems to work well > in practice.
Your journey to reach this final design and implementation may have been painful---I really like the end result. This was an accident waiting to happen.
Thanks for fixing it.
Show 12 quoted lines
> @@ -319,7 +332,10 @@ fi > > exec 5>&1 > exec 6<&0 > -if test "$verbose" = "t" > +if test "$verbose_log" = "t" > +then > + exec 3>>"$GIT_TEST_TEE_OUTPUT_FILE" 4>&3 > +elif test "$verbose" = "t" > then > exec 4>&2 3>&1 > else
OK, unlike "verbose" case where we give 3 (saved stdout) to 1 and 4 (saved stderr) to 2, we send 3 to the output file and 4 to the same.
Makes sense.