Re: [PATCH 2/2] repack: avoid loosening promisor pack objects in partial clones

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 15, 2021, 03:51 UTC
Message-ID: <xmqqo8egurx5.fsf@gitster.g>
In-Reply-To: <20210415010454.4077355-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

Show 9 quoted lines

>> When `-A` and `-d` are used together, besides packing all objects (-A)
>> and removing redundant packs (-d), it also unpack all unreachable
>> objects and deletes them by calling `git pruned-packed`.
>
> I still think of these objects as not unreachable, even though I know
> that pack-objects calls them that (the argument is called
> --unpack-unreachable). So I would say "it also loosens all objects that
> were previously packed but did not go into the new pack", but perhaps
> this is OK too.

Hmph, that is puzzling.  I understand that the operation about

 (1) finding all the objects that are still reachable and send them
     into a newly created pack, and

 (2) among the objects that were previously in the packs, eject
     those that weren't made into the new pack with the previous
     point.

Where did I get it wrong? If all the reachable ones are dealt with with the first point, what is leftover is not reachable, no?