Re: [PATCH] mingw: align symlinks-related rmdir() behavior with Linux

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 29, 2021, 20:03 UTC
Message-ID: <xmqqo8ak51mt.fsf@gitster.g>
In-Reply-To: <pull.1008.git.1627586493659.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 7 quoted lines

> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> When performing a rebase, rmdir() is called on the folder .git/logs. On
> Unix rmdir() exits without deleting anything in case .git/logs is a
> symbolic link but the equivalent functions on Windows (_rmdir, _wrmdir
> and RemoveDirectoryW) do not behave the same and remove the folder if it
> is symlinked even if it is not empty.

The distinction is understandable, and I can see this justifies the patch really nicely.

It is curious why "rebase" causes rmdir on the reflog hierarchy, though. It is also unclear if "rebase" is special in having this behaviour (and if so why), or just an example the problem was observed with and other subcommands may benefit from the same fix.

Will queue with authorship corrected (as you reported in the follow-up).

Thanks.