Re: [PATCH] mingw: align symlinks-related rmdir() behavior with Linux
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Aug 2, 2021, 20:17 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2108022216590.55@tvgsbejvaqbjf.bet>
- In-Reply-To
- <xmqqo8ak51mt.fsf@gitster.g>
Hi Junio,
On Thu, 29 Jul 2021, Junio C Hamano wrote:
Show 18 quoted lines
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> > writes: > > > From: Johannes Schindelin <johannes.schindelin@gmx.de> > > > > When performing a rebase, rmdir() is called on the folder .git/logs. On > > Unix rmdir() exits without deleting anything in case .git/logs is a > > symbolic link but the equivalent functions on Windows (_rmdir, _wrmdir > > and RemoveDirectoryW) do not behave the same and remove the folder if it > > is symlinked even if it is not empty. > > The distinction is understandable, and I can see this justifies the > patch really nicely. > > It is curious why "rebase" causes rmdir on the reflog hierarchy, > though. It is also unclear if "rebase" is special in having this > behaviour (and if so why), or just an example the problem was > observed with and other subcommands may benefit from the same fix.
I augmented the commit message in preparation for v2, specifically to address this concern.
Ciao, Dscho