Re: [PATCH] fetch-pack: speed up loading of refs via commit graph

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 4, 2021, 21:32 UTC
Message-ID: <xmqqo8acnbfd.fsf@gitster.g>
In-Reply-To: <YQr/vLNjZomIe1ME@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 5 quoted lines

> Nice. I've sometimes wondered if parse_object() should be doing this
> optimization itself. Though we'd possibly still want callers (like this
> one) to give us more hints, since we already know the type is
> OBJ_COMMIT. Whereas parse_object() would have to discover that itself
> (though we already incur the extra type lookup there to handle blobs).

Ahh, you read one step further than I did ;-) Yes, if we are already inspecting type there, doing this optimization inside parse_object() becomes much easier to justify.