Re: [PATCH] fetch-pack: speed up loading of refs via commit graph

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 4, 2021, 17:45 UTC
Message-ID: <xmqqczqtp0ip.fsf@gitster.g>
In-Reply-To: <08519b8ab6f395cffbcd5e530bfba6aaf64241a2.1628085347.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 9 quoted lines

> -	if (type == OBJ_COMMIT)
> -		return (struct commit *) parse_object(the_repository, oid);
> +
> +	if (type == OBJ_COMMIT) {
> +		struct commit *commit = lookup_commit(the_repository, oid);
> +		if (!commit || repo_parse_commit(the_repository, commit))
> +			return NULL;
> +		return commit;
> +	}

OK.

Asking parse_object() to turn an object name to an in-core instance of the object is a pretty much standard and generic idiom, but in this codepath, we have already asked for the type and know it must be a commit, so asking parse_commit() that is more specialized makes quite a lot of sense.

Thanks.