Re: [PATCH v2 1/6] refs: open-code deletion of packed refs

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 8, 2022, 00:57 UTC
Message-ID: <xmqqo84n3uyo.fsf@gitster.g>
In-Reply-To: <0739f085b266e65b423ccc14f70cc00c88744459.1641556319.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

This breaks the static analysis job at https://github.com/git/git/runs/4744820766

Show 18 quoted lines

>  refs/packed-backend.h |  6 ++++++
> diff --git a/refs/packed-backend.h b/refs/packed-backend.h
> index f61a73ec25..5e0dd7d08e 100644
> --- a/refs/packed-backend.h
> +++ b/refs/packed-backend.h
> @@ -27,6 +27,12 @@ int packed_refs_lock(struct ref_store *ref_store, int flags, struct strbuf *err)
>  void packed_refs_unlock(struct ref_store *ref_store);
>  int packed_refs_is_locked(struct ref_store *ref_store);
>  
> +int packed_refs_delete_refs(struct ref_store *ref_store,
> +			    struct ref_transaction *transaction,
> +			    const char *msg,
> +			    struct string_list *refnames,
> +			    unsigned int flags);
> +
>  /*
>   * Return true if `transaction` really needs to be carried out against
>   * the specified packed_ref_store, or false if it can be skipped

    HDR reftable/block.h
In file included from refs/packed-backend.hcc:2:0:
./refs/packed-backend.h:33:15: error: ‘struct string_list’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
        struct string_list *refnames,
               ^~~~~~~~~~~
cc1: all warnings being treated as errors
make: *** [refs/packed-backend.hco] Error 1
make: *** Waiting for unfinished jobs....
Makefile:3029: recipe for target 'refs/packed-backend.hco' failed
Error: Process completed with exit code 1.