Re: [PATCH v2 6/6] refs: skip hooks when deleting uncovered packed refs

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 10, 2022, 18:00 UTC
Message-ID: <xmqq4k6b1nfi.fsf@gitster.g>
In-Reply-To: <YdwyFmqs0MhU0wA6@ncase>

Patrick Steinhardt <ps@pks.im> writes:

Show 7 quoted lines

> It does so only if the ref exists in either the loose or packed backend
> though. If trying to update a ref which exists in neither of those, then
> the reference transaction would fail with an "unable to resolve
> reference" error in `lock_raw_ref()`.
>
> So this should behave as expected: deleting a packed ref calls the hook
> once, deleting a nonexistent ref fails and doesn't call the hook at all.

OK. Your explanation deserves to be in the log message for those who ask questions next time, not lost in the archive in a message just answering my question and explaining it only for me. After all, that is why I ask questions in my reviews.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.