git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Review process improvements: drafting a ReviewingPatches doc

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 11, 2022, 17:28 UTC
Message-ID
<xmqqo83dcnxq.fsf@gitster.g>
In-Reply-To
<20220210233346.1009735-1-calvinwan@google.com>
calvinwan@google.com writes:
Show 7 quoted lines
> In continuation of Emily’s "Review process improvements"[1], I am
> drafting a ReviewingPatches doc to help standardize the review process
> here on the git mailing list and to provide a rubric/checklist for new
> reviewers. In order to do so, I am looking to compile examples and
> input from everyone by asking the list a set of questions biweekly.
> Please contextualize your answer in terms of whether this was a
> maintainer, individual, or drive-by review.

Often people other than the patch contributors themselves find others' reviews a useful learning opportunity. I take it that your "contextualize" request is asking for comments like "As the maintainer, I found this review by an area expert very helpful because ...", as well as "I sent this patch and a drive-by typofix at this URL was not very helpful"?

When soliciting input from the list, it would probably make it easier for others if you led by example by sending your answers, to show the level of detail you'd find useful.

Previous: calvinwan@google.comNext: Calvin Wan
Message 2 of 3 in “Review process improvements: drafting a ReviewingPatches doc”
  1. calvinwan@google.comFeb 10, 2022
  2. Junio C HamanoFeb 11, 2022
  3. Calvin WanFeb 11, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.