git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Review process improvements: drafting a ReviewingPatches doc

From
calvinwan@google.com <calvinwan@google.com>
Date
Feb 10, 2022, 23:33 UTC
Message-ID
<20220210233346.1009735-1-calvinwan@google.com>
Hi all,

In continuation of Emily’s "Review process improvements"[1], I am drafting a ReviewingPatches doc to help standardize the review process here on the git mailing list and to provide a rubric/checklist for new reviewers. In order to do so, I am looking to compile examples and input from everyone by asking the list a set of questions biweekly. Please contextualize your answer in terms of whether this was a maintainer, individual, or drive-by review.

Maintainer: in the context of the overall project, is this series a
good idea? Does it interact well with other features? Is it
maintainable in the long term?
Individual: in the context of the individual's own experience, is this
series a good idea? Is the implementation readable, correct, and
efficient?

Drive-by / nitpicks: does not answer whether the series is a good idea. Makes suggestions for missing pieces, bugs, and/or code style.

Here are the first set of questions I had in mind:

What is the best review(s) that you have ever received? What was especially constructive about this review and do you feel like it could be improved upon or is missing something? Conversely, what is the best review(s) that you have ever given? Feel free to leave examples for each of the review types.

[1] https://lore.kernel.org/git/YbvBvch8JcHED+A9@google.com/
Next: Junio C Hamano
Message 1 of 3 in “Review process improvements: drafting a ReviewingPatches doc”
  1. calvinwan@google.comFeb 10, 2022
  2. Junio C HamanoFeb 11, 2022
  3. Calvin WanFeb 11, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.