Re: [PATCH] ls-tree: test for the regression in 9c4d58ff2c3

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 2, 2022, 17:48 UTC
Message-ID: <xmqqo7zbnehy.fsf@gitster.g>
In-Reply-To: <nycvar.QRO.7.76.6.2206021703110.349@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 8 quoted lines

>> +test_ls_tree_format_mode_output () {
>> +	local opts=$1 &&
>
> This line does not quote `$1`, but...
>
> ... this line passes a first argument that contains spaces. Hence the
> tests fail in CI:
> https://github.com/git/git/runs/6703333447?check_suite_focus=true

We had a portability discussion not so in distant past on "local".

  https://lore.kernel.org/git/xmqqsftc3nd6.fsf@gitster.g/

The conclusion from the thread IIRC is

 * Very safe

	local var; var=$1

 * Probably OK

	local var="$1"

 * Not portable

	local var=$1

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.