From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 02 Jun 2022 17:48:09 GMT
Subject: Re: [PATCH] ls-tree: test for the regression in 9c4d58ff2c3
Message-ID: <xmqqo7zbnehy.fsf@gitster.g>
In-Reply-To: <nycvar.QRO.7.76.6.2206021703110.349@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

>> +test_ls_tree_format_mode_output () {
>> +	local opts=$1 &&
>
> This line does not quote `$1`, but...
>
> ... this line passes a first argument that contains spaces. Hence the
> tests fail in CI:
> https://github.com/git/git/runs/6703333447?check_suite_focus=true

We had a portability discussion not so in distant past on "local".

  https://lore.kernel.org/git/xmqqsftc3nd6.fsf@gitster.g/

The conclusion from the thread IIRC is

 * Very safe

	local var; var=$1

 * Probably OK

	local var="$1"

 * Not portable

	local var=$1

Thanks.