Re: [PATCH] branch: allow "-" as a short-hand for "previous branch"

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 25, 2022, 16:23 UTC
Message-ID: <xmqqo7w82sx1.fsf@gitster.g>
In-Reply-To: <4d8eb431-dc25-5ea9-14b8-3f84ae0c1561@gmail.com>

Rubén Justo <rjusto@gmail.com> writes:

Show 7 quoted lines

> struct rev_info *revs, struct s
>                 revarg_opt |= REVARG_CANNOT_BE_FILENAME;
>         for (left = i = 1; i < argc; i++) {
>                 const char *arg = argv[i];
> -               if (!seen_end_of_options && *arg == '-') {
> +               if (!seen_end_of_options && *arg == '-' &&
> !strchr(".^~:@", arg[1])) {

Yuck. I really didn't want to see that strchr() or any other logic that _knows_ what letter is allowed after a "rev". It will be impossible to keep it in sync with the real code paths that needs to know and parses these syntactical constructs, and folks new to the codebase will never be able to tell at a first glance if the above is sufficient (or what the strchr() is doing).