Re: [PATCH] branch: allow "-" as a short-hand for "previous branch"
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Aug 16, 2022, 09:31 UTC
- Message-ID
- <9so90892-25nr-0s4o-q98n-2qo76r3s89p3@tzk.qr>
- In-Reply-To
- <9693b83f-551e-e579-b267-af1d633dc381@gmail.com>
Hi Rubén,
On Sat, 13 Aug 2022, Rubén Justo wrote:
Show 26 quoted lines
> On Mon, Aug 8, 2022 at 4:47 PM Junio C Hamano<gitster@pobox.com> wrote:
>
> > The "-d" and "-D" options being the more detructive ones among other
> > operation modes of the command, I am not sure if this change is even
> > desirable. Even if it were, the implementation to special case a
> > single argument case like this ...
> >
> > > + if ((argc == 1) && !strcmp(argv[0], "-")) {
> > > + argv[0] = "@{-1}";
> > > + }
> > ... (by the way, we don't write braces around a single statement
> > block) would invite cries from confused users why none of these ...
> >
> > $ git branch -m - new-name
> > $ git branch new-branch -
> > $ git branch --set-upstream-to=<upstream> -
> >
> > work and "-" works only for deletion.
>
> Agree. But the approach is to ease the deletion of previous branch,
> aligned with merge:
>
> $ git merge - -
> merge: - - not something we can merge
> $ git merge - old-branch
> merge: - - not something we can mergeThis is confusing me: how is the patch supporting `git branch -d -` aligned with the presented `git merge` invocations?
In any case, you now have two sets of feedback that say that special-casing one particular command-line and leaving all other invocations using `-` unchanged is undesirable, if you needed more than one such feedback.
Ciao, Dscho