Re: [PATCH] t5516: fail to run in verbose mode

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 22, 2022, 04:19 UTC
Message-ID: <xmqqo7szsjs4.fsf@gitster.g>
In-Reply-To: <20221121134040.12260-1-worldhello.net@gmail.com>

Jiang Xin <worldhello.net@gmail.com> writes:

Show 9 quoted lines

> From: Jiang Xin <zhiyou.jx@alibaba-inc.com>
>
> The test case "push with config push.useBitmap" of t5516 was introduced
> in commit 82f67ee13f (send-pack.c: add config push.useBitmaps,
> 2022-06-17). It won't work in verbose mode, e.g.:
>
>     $ sh t5516-fetch-push.sh --run='1,115' -v
>
> This is because "git-push" will run in a tty in this case, and the

Right. "-v" involves redirecting the stdout/stderr of the commands being run in the test to stdout/stderr in the environment the tests are run, so

    $ sh t5516-fetch-push.sh --run='1,115' -v >log 2>&1

would have succeeded correctly. Forcing the behaviour with the "--quiet" option is certainly a good way to gain stability.