RE: [Internet][PATCH] t5516: fail to run in verbose mode
- From
kylezhao (赵柯宇) <kylezhao@tencent.com>
- Date
- Nov 22, 2022, 02:22 UTC
- Message-ID
- <a7abaa2cc8d248faa50ad95fc3670ee0@tencent.com>
- In-Reply-To
- <20221121134040.12260-1-worldhello.net@gmail.com>
Show 11 quoted lines
> The test case "push with config push.useBitmap" of t5516 was introduced in > commit 82f67ee13f (send-pack.c: add config push.useBitmaps, 2022-06-17). It > won't work in verbose mode, e.g.: > > $ sh t5516-fetch-push.sh --run='1,115' -v > > This is because "git-push" will run in a tty in this case, and the subcommand > "git pack-objects" will contain an argument "--progress" > instead of "-q". Adding a specific option "--quiet" to "git push" will get a stable > result for t5516. >
That's true. Thanks for noticing and fixing.
I didn't consider this usage of test case, and it works after your patch.
Thanks, Kyle