Re: [PATCH] wt-status: Don't find scissors line beyond buf len

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 7, 2024, 21:24 UTC
Message-ID: <xmqqo7bpka6e.fsf@gitster.g>
In-Reply-To: <f8de2b3a-9e12-49fe-a7d9-481317f10c4d@app.fastmail.com>

"Kristoffer Haugsbakk" <code@khaugsbakk.name> writes:

Show 7 quoted lines

> On Thu, Mar 7, 2024, at 21:47, Junio C Hamano wrote:
>> Signed-off-by: Florian Schmidt <flosch@nutanix.com>
>> Reviewed-by: Jonathan Davies <jonathan.davies@nutanix.com>
>> [jc: tweaked the commit log message and the implementation a bit]
>
> Just a question. Given the imperative mood principle/rule, why are these
> bracket changelog lines always written in the past tense?

These are not giving orders to the code to become like so. The trailer block records what happend to the patch in chronological order---think of those written there at one level higher level, "meta" comments.