Re: [PATCH] wt-status: Don't find scissors line beyond buf len

From: Kristoffer Haugsbakk <code@khaugsbakk.name>
Date: Mar 7, 2024, 21:30 UTC
Message-ID: <6acdc464-825e-48bd-a2d6-97671b58f879@app.fastmail.com>
In-Reply-To: <CAPig+cRNa22A=fEmc__JvEjYiVF-QG8o7w0gukhbeL3e-PwVkA@mail.gmail.com>

On Thu, Mar 7, 2024 at 4:24 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 11 quoted lines

>> "Kristoffer Haugsbakk" <code@khaugsbakk.name> writes:
>> > On Thu, Mar 7, 2024, at 21:47, Junio C Hamano wrote:
>> >> [jc: tweaked the commit log message and the implementation a bit]
>> >
>> > Just a question. Given the imperative mood principle/rule, why are these
>> > bracket changelog lines always written in the past tense?
>>
>> These are not giving orders to the code to become like so.  The
>> trailer block records what happend to the patch in chronological
>> order---think of those written there at one level higher level,
>> "meta" comments.

And when I think about it the trailers themselves are of course in the past tense…

Thanks guys

On Thu, Mar 7, 2024, at 22:26, Eric Sunshine wrote:

Show 5 quoted lines

>
> Also, they are not always written in past tense[*].
>
> [*]:
> https://lore.kernel.org/git/20240112171910.11131-1-ericsunshine@charter.net/

-- 
Kristoffer Haugsbakk