git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 2/2] send-email: make it easy to discern the messages for each patch

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 27, 2024, 18:18 UTC
Message-ID
<xmqqo79u4qlc.fsf@gitster.g>
In-Reply-To
<xmqqsez64r4d.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
> Well, v1 and v3-v5 saw comments only from me.  There was a comment
> on v2 by Kristoffer Haugsbakk about phrasing in proposed log
> message.  v6 had Eric's "Meh, either way".

FWIW, somewhere between v2 and v3 may have been a good place to stop.

"After calling send_message(), give an extra blank line before the next message" was extremely easy to see why it was a good idea. Mixing it with "oh, during the process of a single invocation of send_message(), there may be other places that want extra blank lines" made the changes less focused. Personally I lost interest in the series at around that point.

Previous: Junio C HamanoNext: Dragan Simic
Message 14 of 15 in “send-email: make produced outputs more readable”
  1. 0/2 send-email: make produced outputs more readableDragan Simic, Apr 10, 2024
  2. 1/2 send-email: move newline characters out of a few translatable stringsDragan Simic, Apr 10, 2024
  3. Junio C HamanoApr 10, 2024
  4. Dragan SimicApr 13, 2024
  5. 2/2 send-email: make it easy to discern the messages for each patchDragan Simic, Apr 10, 2024
  6. Junio C HamanoApr 10, 2024
  7. Eric SunshineApr 10, 2024
  8. Dragan SimicApr 13, 2024
  9. Dragan SimicApr 13, 2024
  10. Dragan SimicApr 27, 2024
  11. Junio C HamanoApr 27, 2024
  12. Dragan SimicApr 27, 2024
  13. Junio C HamanoApr 27, 2024
  14. Junio C HamanoApr 27, 2024
  15. Dragan SimicApr 28, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.