Re: [PATCH v6 2/2] send-email: make it easy to discern the messages for each patch

From: Dragan Simic <dsimic@manjaro.org>
Date: Apr 13, 2024, 06:10 UTC
Message-ID: <fcf3331de77a623bceec6da6f3acbfed@manjaro.org>
In-Reply-To: <CAPig+cQ+VV_Raxsk31vG8H4D5NjLsW5oFCA-o28raqrSRhi1TQ@mail.gmail.com>

Hello Eric,

On 2024-04-11 00:59, Eric Sunshine wrote:

Show 22 quoted lines

> On Wed, Apr 10, 2024 at 12:28 PM Junio C Hamano <gitster@pobox.com> 
> wrote:
>> Dragan Simic <dsimic@manjaro.org> writes:
>> >     MIME-Version: 1.0
>> >     Content-Transfer-Encoding: 8bit
>> >
>> >     Send this email? ([y]es|[n]o|[e]dit|[q]uit|[a]ll): y
>> >
>> >     OK. Log says:
>> >     Server: smtp.example.com
>> 
>> This is obviously in the realm of subjective preference, but I find
>> that the prompt line is distinct enough among all other output that
>> we do not need an extra blank line to locate them.
>> 
>> I'll let others comment as the "blank around prompt" smells quite
>> subjective and do not want to be the sole reviewer on it.
> 
> For what it's worth, I had the same reaction about the extra blank
> line related to the prompt being unnecessary, but I didn't feel
> strongly enough to say anything about it, and I still don't feel
> strongly enough to suggest dropping this change.

Basically, I went with a rather simple reasoning: the confirmation prompts, just like the SMTP statuses, aren't part of the emitted SMTP traces and patch descriptions. As such, separating the prompts with vertical whitespace is actually consistent, and should help with the overall readability, by taking the prompts visually out of the other produced messages.