git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] [Outreachy] patch-ids: fix const correctness

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 13, 2025, 18:33 UTC
Message-ID
<xmqqo6qa1wjg.fsf@gitster.g>
In-Reply-To
<CAFpMFfAHA8OfVXKVVSSAQ5p+B8ngT3p54on1HpM+n2qs3P1rHA@mail.gmail.com>
Okhuomon Ajayi <okhuomonajayi54@gmail.com> writes:
> Thanks for explaining! I get it now the NEEDSWORK comment isn’t needed
> since the hashmap API is supposed to have cmpfn_data as const. I’ve
> removed the comment and didn’t change anything else

The NEEDSWORK comment is about going even further, starting from question if hashmap should really be using "const" in the first place, to sort things out among all the components involved (including other users of the hashmap API).

A commit that does not do the necessary study and just removes the needswork comment is simply irresponsible, no?

Previous: Okhuomon AjayiNext: Okhuomon Ajayi
Message 6 of 7 in “[Outreachy] patch-ids: fix const correctness”
  1. [Outreachy] patch-ids: fix const correctnessOkhuomon Ajayi, Oct 13, 2025
  2. Junio C HamanoOct 13, 2025
  3. Okhuomon AjayiOct 13, 2025
  4. Junio C HamanoOct 13, 2025
  5. Okhuomon AjayiOct 13, 2025
  6. Junio C HamanoOct 13, 2025
  7. Okhuomon AjayiOct 13, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.