[PATCH] [Outreachy] patch-ids: fix const correctness
- From
- Okhuomon Ajayi <okhuomonajayi54@gmail.com>
- Date
- Oct 13, 2025, 16:53 UTC
- Message-ID
- <20251013165320.201333-1-okhuomonajayi54@gmail.com>
The `patch_id_neq()` function received a pointer to diff options via `cmpfn_data` but cast it to a non-const type. This caused a const correctness warning and could potentially allow unintended modification of read-only data.
Fix this by casting to `const struct diff_options *` instead, removing the outdated NEEDSWORK comment in the process.
Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com> --- patch-ids.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/patch-ids.c b/patch-ids.c index a5683b462c..b6b808332f 100644 --- a/patch-ids.c +++ b/patch-ids.c @@ -41,8 +41,8 @@ static int patch_id_neq(const void *cmpfn_data, const struct hashmap_entry *entry_or_key, const void *keydata UNUSED) { - /* NEEDSWORK: const correctness? */ - struct diff_options *opt = (void *)cmpfn_data; + + const struct diff_options *opt = (void *)cmpfn_data; struct patch_id *a, *b; a = container_of(eptr, struct patch_id, ent);
-- 2.43.0