git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] index-pack: retain child bases in delta cache

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 11, 2026, 17:29 UTC
Message-ID
<xmqqo6hhnfz1.fsf@gitster.g>
In-Reply-To
<20260611065748.GF2191159@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 23 quoted lines
> On Wed, Jun 10, 2026 at 07:51:19AM -0700, Junio C Hamano wrote:
>
>> Arijit Banerjee <arijit91@gmail.com> writes:
>> 
>> > Apologies, my earlier replies were sent through GitHub's notification
>> > emails and appeared only as PR comments, so they did not reach the mailing
>> > list.
>> >
>> > On Thu, Jun 4, 2026, Jeff King wrote:
>> >> So I am happy with either v2 or v3.
>> >
>> > I also did not see a meaningful performance difference between v2 and v3.
>> > I am happy with either direction and defer to the maintainers on whether
>> > v3's more precise release is worth the added complexity.
>> 
>> I have no strong preference either way.
>
> Nor me. I'd probably go with v2 simply because it is shorter and less
> code. If there is an optimization whose effect we cannot measure, it is
> probably not worth even the few lines to have it. It could always be
> resurrected if somebody finds a case where it matters.
>
> -Peff

Sounds like a good idea. I just resurrected v2 from my reflog ;-) Let's mark the topic for 'next'.

Thanks.
Previous: Jeff King
Message 11 of 11 in “index-pack: retain child bases in delta cache”
  1. index-pack: retain child bases in delta cacheArijit Banerjee via GitGitGadget, May 29, 2026
  2. Derrick StoleeJun 1, 2026
  3. index-pack: retain child bases in delta cacheArijit Banerjee via GitGitGadget, Jun 1, 2026
  4. Jeff KingJun 2, 2026
  5. index-pack: retain child bases in delta cacheArijit Banerjee via GitGitGadget, Jun 3, 2026
  6. Derrick StoleeJun 3, 2026
  7. Jeff KingJun 4, 2026
  8. Arijit BanerjeeJun 5, 2026
  9. Junio C HamanoJun 10, 2026
  10. Jeff KingJun 11, 2026
  11. Junio C HamanoJun 11, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.