Re: [PATCH v3] index-pack: retain child bases in delta cache
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 11, 2026, 17:29 UTC
- Message-ID
- <xmqqo6hhnfz1.fsf@gitster.g>
- In-Reply-To
- <20260611065748.GF2191159@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 23 quoted lines
> On Wed, Jun 10, 2026 at 07:51:19AM -0700, Junio C Hamano wrote: > >> Arijit Banerjee <arijit91@gmail.com> writes: >> >> > Apologies, my earlier replies were sent through GitHub's notification >> > emails and appeared only as PR comments, so they did not reach the mailing >> > list. >> > >> > On Thu, Jun 4, 2026, Jeff King wrote: >> >> So I am happy with either v2 or v3. >> > >> > I also did not see a meaningful performance difference between v2 and v3. >> > I am happy with either direction and defer to the maintainers on whether >> > v3's more precise release is worth the added complexity. >> >> I have no strong preference either way. > > Nor me. I'd probably go with v2 simply because it is shorter and less > code. If there is an optimization whose effect we cannot measure, it is > probably not worth even the few lines to have it. It could always be > resurrected if somebody finds a case where it matters. > > -Peff
Sounds like a good idea. I just resurrected v2 from my reflog ;-) Let's mark the topic for 'next'.
Thanks.