Re: [PATCH v3] index-pack: retain child bases in delta cache

From: Jeff King <peff@peff.net>
Date: Jun 11, 2026, 06:57 UTC
Message-ID: <20260611065748.GF2191159@coredump.intra.peff.net>
In-Reply-To: <xmqqldcmxxco.fsf@gitster.g>

On Wed, Jun 10, 2026 at 07:51:19AM -0700, Junio C Hamano wrote:

Show 14 quoted lines

> Arijit Banerjee <arijit91@gmail.com> writes:
> 
> > Apologies, my earlier replies were sent through GitHub's notification
> > emails and appeared only as PR comments, so they did not reach the mailing
> > list.
> >
> > On Thu, Jun 4, 2026, Jeff King wrote:
> >> So I am happy with either v2 or v3.
> >
> > I also did not see a meaningful performance difference between v2 and v3.
> > I am happy with either direction and defer to the maintainers on whether
> > v3's more precise release is worth the added complexity.
> 
> I have no strong preference either way.

Nor me. I'd probably go with v2 simply because it is shorter and less code. If there is an optimization whose effect we cannot measure, it is probably not worth even the few lines to have it. It could always be resurrected if somebody finds a case where it matters.

-Peff