git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] sequencer: release the ODB before spawning git commit

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 24, 2026, 14:36 UTC
Message-ID
<xmqqo6ersi07.fsf@gitster.g>
In-Reply-To
<a786e6c0-1c17-4121-8623-b4541478a88f@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
> This looks fine as an immediate fix for the bug but I wonder if we 
> should pass "-c gc.auto=false" when we fork "git commit" from the 
> sequencer. We call run_auto_maintenance() at the end of the rebase and 
> its not clear to me that repacking during the rebase is helpful.

This is a bit amusing as I was reading old discussion the other day around the constant 6700 [*] and saw it discused that because "commit" triggers auto-gc, there was no point in doing so in "rebase", which does series of "commit" invocations [*]. With small projects and short rebases I tend to agree with you that gc at the end of a rebase session should be plenty, but given the widespread use of Git, itt may not apply to everybody.

Show 6 quoted lines
> Another 
> thought I had was whether we should automatically close the object 
> database when forking another git command. I'm not sure how easy that is 
> to implement but it would prevent future regressions and I assuming 
> re-opening the object store is cheap compared to forking another git 
> command.

I think it is a great approach to study how feasible it is, as we will not have to sprinkle fixes like the one proposed to many code paths. Thanks for raising it.

[References]
 * https://lore.kernel.org/git/?q=6700+d:..20071231
 * https://lore.kernel.org/git/20070906023934.GI18160@spearce.org/
Previous: Phillip WoodNext: Phillip Wood
Message 6 of 7 in “sequencer: release the ODB before spawning git commit”
  1. sequencer: release the ODB before spawning git commitJohannes Schindelin via GitGitGadget, Aug 10, 2026
  2. Junio C HamanoAug 11, 2026
  3. sequencer: release the ODB before spawning git commitJohannes Schindelin via GitGitGadget, Aug 12, 2026
  4. Junio C HamanoAug 12, 2026
  5. Phillip WoodAug 24, 2026
  6. Junio C HamanoAug 24, 2026
  7. Phillip WoodAug 25, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.