Re: [PATCH v2] sequencer: release the ODB before spawning git commit
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 24, 2026, 14:36 UTC
- Message-ID
- <xmqqo6ersi07.fsf@gitster.g>
- In-Reply-To
- <a786e6c0-1c17-4121-8623-b4541478a88f@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
> This looks fine as an immediate fix for the bug but I wonder if we > should pass "-c gc.auto=false" when we fork "git commit" from the > sequencer. We call run_auto_maintenance() at the end of the rebase and > its not clear to me that repacking during the rebase is helpful.
This is a bit amusing as I was reading old discussion the other day around the constant 6700 [*] and saw it discused that because "commit" triggers auto-gc, there was no point in doing so in "rebase", which does series of "commit" invocations [*]. With small projects and short rebases I tend to agree with you that gc at the end of a rebase session should be plenty, but given the widespread use of Git, itt may not apply to everybody.
Show 6 quoted lines
> Another > thought I had was whether we should automatically close the object > database when forking another git command. I'm not sure how easy that is > to implement but it would prevent future regressions and I assuming > re-opening the object store is cheap compared to forking another git > command.
I think it is a great approach to study how feasible it is, as we will not have to sprinkle fixes like the one proposed to many code paths. Thanks for raising it.
[References]
* https://lore.kernel.org/git/?q=6700+d:..20071231 * https://lore.kernel.org/git/20070906023934.GI18160@spearce.org/