Re: [PATCH v2] sequencer: release the ODB before spawning git commit
- From
- Phillip Wood <phillip.wood123@gmail.com>
- Date
- Aug 25, 2026, 15:54 UTC
- Message-ID
- <472164ed-7707-4842-a275-0356cb0e7c71@gmail.com>
- In-Reply-To
- <xmqqo6ersi07.fsf@gitster.g>
On 24/08/2026 15:36, Junio C Hamano wrote:
Show 14 quoted lines
> Phillip Wood <phillip.wood123@gmail.com> writes: > >> This looks fine as an immediate fix for the bug but I wonder if we >> should pass "-c gc.auto=false" when we fork "git commit" from the >> sequencer. We call run_auto_maintenance() at the end of the rebase and >> its not clear to me that repacking during the rebase is helpful. > > This is a bit amusing as I was reading old discussion the other day > around the constant 6700 [*] and saw it discused that because > "commit" triggers auto-gc, there was no point in doing so in > "rebase", which does series of "commit" invocations [*]. With small > projects and short rebases I tend to agree with you that gc at the > end of a rebase session should be plenty, but given the widespread > use of Git, itt may not apply to everybody.
That's a coincidence. These days we avoid running "git commit" for simple picks, but we do run it when rebasing a merge and I suspect large rebases probably include merges. So we will probably do trigger gc during large rebases even if there are no conflicts or commits being reworded (which I think are the only two other cases where we fork "git commit").
Thanks
Phillip
Show 16 quoted lines
>> Another >> thought I had was whether we should automatically close the object >> database when forking another git command. I'm not sure how easy that is >> to implement but it would prevent future regressions and I assuming >> re-opening the object store is cheap compared to forking another git >> command. > > I think it is a great approach to study how feasible it is, as we > will not have to sprinkle fixes like the one proposed to many code > paths. Thanks for raising it. > > > [References] > > * https://lore.kernel.org/git/?q=6700+d:..20071231 > * https://lore.kernel.org/git/20070906023934.GI18160@spearce.org/