git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Uses git-credential for git-imap-send

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 29, 2014, 17:19 UTC
Message-ID
<xmqqmwf4kq9i.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20140429030534.GA12118@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 20 quoted lines
> On Mon, Apr 28, 2014 at 08:00:04PM -0700, Dan Albert wrote:
>
>> > I noticed that we are just filling in the password here, since we'll
>> > always fill cred.username from srvc->user. The lines directly above are:
>> > 
>> >         if (!srvc->user) {
>> >                 fprintf(stderr, "Skipping server %s, no user\n", srvc->host);
>> >                 goto bail;
>> >         }
>> > 
>> > That comes from the imap.user config variable. I wonder if we should
>> > just pass it off to credential_fill() in this case, too, which will fill
>> > in the username if necessary.
>> [...]
>> 
>> Yeah, doubtful anyone cares, but it's simple enough to do.
>
> Thanks, I think the result looks good.
>
> Acked-by: Jeff King <peff@peff.net>

OK, luckily I haven't merged the one from the yesterday yet, so I'll replace ;-)

Thanks for working on this, Dan, and as always thanks for reviewing, Peff.

Previous: Jeff KingNext: Jeff King
Message 7 of 8 in “Uses git-credential for git-imap-send”
  1. Uses git-credential for git-imap-sendDan Albert, Apr 26, 2014
  2. Jeff KingApr 26, 2014
  3. Uses git-credential for git-imap-sendDan Albert, Apr 27, 2014
  4. Jeff KingApr 28, 2014
  5. Uses git-credential for git-imap-sendDan Albert, Apr 29, 2014
  6. Jeff KingApr 29, 2014
  7. Junio C HamanoApr 29, 2014
  8. Jeff KingApr 27, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.