From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 29 Apr 2014 17:19:05 GMT
Subject: Re: [PATCH] Uses git-credential for git-imap-send
Message-ID: <xmqqmwf4kq9i.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140429030534.GA12118@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Mon, Apr 28, 2014 at 08:00:04PM -0700, Dan Albert wrote:
>
>> > I noticed that we are just filling in the password here, since we'll
>> > always fill cred.username from srvc->user. The lines directly above are:
>> > 
>> >         if (!srvc->user) {
>> >                 fprintf(stderr, "Skipping server %s, no user\n", srvc->host);
>> >                 goto bail;
>> >         }
>> > 
>> > That comes from the imap.user config variable. I wonder if we should
>> > just pass it off to credential_fill() in this case, too, which will fill
>> > in the username if necessary.
>> [...]
>> 
>> Yeah, doubtful anyone cares, but it's simple enough to do.
>
> Thanks, I think the result looks good.
>
> Acked-by: Jeff King <peff@peff.net>

OK, luckily I haven't merged the one from the yesterday yet, so I'll
replace ;-)

Thanks for working on this, Dan, and as always thanks for reviewing,
Peff.