git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v12 11/11] Documentation: add documentation for 'git interpret-trailers'

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 30, 2014, 06:40 UTC
Message-ID
<xmqqmwcuzyqx.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20140629.113731.1129545703421115235.chriscool@tuxfamily.org>
Christian Couder <chriscool@tuxfamily.org> writes:
Show 13 quoted lines
>> While I agree with Michael on the other thread that we should limit
>> the syntax and start with ':' only, if you really want to allow
>> random syntax like "Bug #12345" and "Acked-by= Peff", for which you
>> have demonstrations in the tests in the other patch, the above rule
>> should be updated to also allow prefix matches to possible set of
>> keys defined by the user, so that an existing line that is produced
>> by your tool, e.g. "Acked-by= Peff", can be picked up as matching
>> with some token having a key "Acked-by= ".  Otherwise, the input
>> side of your tool is inconsistent with the output side of your own
>> tool, and that will make the flexiblity of the output side useless.
>
> I don't think that the flexibility of the output side would be
> useless.
Flexibility is useful, only if you can control it.
Show 5 quoted lines
> We already emit stuff like:
>
> (cherry picked from commit f72baf07969242882128aff4c95ec8059e7fd054)
>
> and we don't care about any input side when we do that.

That is something you may want to _fix_, not take as an excuse to make things worse, no?

Previous: Christian CouderNext: Junio C Hamano
Message 16 of 19 in “Add interpret-trailers builtin”
  1. 00/11 Add interpret-trailers builtinChristian Couder, May 25, 2014
  2. 01/11 trailer: add data structures and basic functionsChristian Couder, May 25, 2014
  3. 02/11 trailer: process trailers from input message and argumentsChristian Couder, May 25, 2014
  4. 03/11 trailer: read and process config informationChristian Couder, May 25, 2014
  5. 04/11 trailer: process command line trailer argumentsChristian Couder, May 25, 2014
  6. 05/11 trailer: parse trailers from file or stdinChristian Couder, May 25, 2014
  7. 06/11 trailer: put all the processing together and printChristian Couder, May 25, 2014
  8. 07/11 trailer: add interpret-trailers commandChristian Couder, May 25, 2014
  9. 08/11 trailer: add tests for "git interpret-trailers"Christian Couder, May 25, 2014
  10. Junio C HamanoMay 28, 2014
  11. 09/11 trailer: execute command from 'trailer.<name>.command'Christian Couder, May 25, 2014
  12. 10/11 trailer: add tests for commands in config fileChristian Couder, May 25, 2014
  13. 11/11 Documentation: add documentation for 'git interpret-trailers'Christian Couder, May 25, 2014
  14. Junio C HamanoMay 28, 2014
  15. Christian CouderJun 29, 2014
  16. Junio C HamanoJun 30, 2014
  17. Junio C HamanoMay 28, 2014
  18. Jakub NarębskiJun 30, 2014
  19. Christian CouderJul 1, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.