git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v12 08/11] trailer: add tests for "git interpret-trailers"

From
Junio C Hamano <gitster@pobox.com>
Date
May 28, 2014, 19:28 UTC
Message-ID
<xmqqioopd7oe.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20140525053223.5329.36492.chriscool@tuxfamily.org>
Christian Couder <chriscool@tuxfamily.org> writes:
> +test_expect_success 'using "where = before" for a token in the middle of the message' '
> +	git config trailer.review.key "Reviewed-by:" &&

Don't you want to adjust this to have trailing SP, just like you adjusted other ones like "Fixes: " in this round?

Previous: Christian CouderNext: Christian Couder
Message 10 of 19 in “Add interpret-trailers builtin”
  1. 00/11 Add interpret-trailers builtinChristian Couder, May 25, 2014
  2. 01/11 trailer: add data structures and basic functionsChristian Couder, May 25, 2014
  3. 02/11 trailer: process trailers from input message and argumentsChristian Couder, May 25, 2014
  4. 03/11 trailer: read and process config informationChristian Couder, May 25, 2014
  5. 04/11 trailer: process command line trailer argumentsChristian Couder, May 25, 2014
  6. 05/11 trailer: parse trailers from file or stdinChristian Couder, May 25, 2014
  7. 06/11 trailer: put all the processing together and printChristian Couder, May 25, 2014
  8. 07/11 trailer: add interpret-trailers commandChristian Couder, May 25, 2014
  9. 08/11 trailer: add tests for "git interpret-trailers"Christian Couder, May 25, 2014
  10. Junio C HamanoMay 28, 2014
  11. 09/11 trailer: execute command from 'trailer.<name>.command'Christian Couder, May 25, 2014
  12. 10/11 trailer: add tests for commands in config fileChristian Couder, May 25, 2014
  13. 11/11 Documentation: add documentation for 'git interpret-trailers'Christian Couder, May 25, 2014
  14. Junio C HamanoMay 28, 2014
  15. Christian CouderJun 29, 2014
  16. Junio C HamanoJun 30, 2014
  17. Junio C HamanoMay 28, 2014
  18. Jakub NarębskiJun 30, 2014
  19. Christian CouderJul 1, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.