git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 2/3] Introduce GIT_MMAP_LIMIT to allow testing expected mmap size

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 22, 2014, 15:57 UTC
Message-ID
<xmqqmwawpldt.fsf@gitster.dls.corp.google.com>
In-Reply-To
<0342479D-7C9F-42E6-9B79-745AEDE57EB5@zib.de>
Steffen Prohaska <prohaska@zib.de> writes:
Show 5 quoted lines
>>> +	if (limit == -1) {
>>> +		const char *env = getenv("GIT_MMAP_LIMIT");
>>> +		limit = env ? atoi(env) * 1024 : 0;
>
> ... this should then be changed to atol(env), and ...

In the real codepath (not debugging aid like this) we try to avoid atoi/atol so that we can catch errors like feeding "123Q" and parsing it as 123.

Previous: Steffen ProhaskaNext: Junio C Hamano
Message 6 of 9 in “Stream fd to clean filter, GIT_MMAP_LIMIT”
  1. 0/3 Stream fd to clean filter, GIT_MMAP_LIMITSteffen Prohaska, Aug 21, 2014
  2. 1/3 convert: Refactor would_convert_to_git() to single arg 'path'Steffen Prohaska, Aug 21, 2014
  3. 2/3 Introduce GIT_MMAP_LIMIT to allow testing expected mmap sizeSteffen Prohaska, Aug 21, 2014
  4. Junio C HamanoAug 21, 2014
  5. Steffen ProhaskaAug 22, 2014
  6. Junio C HamanoAug 22, 2014
  7. Junio C HamanoAug 22, 2014
  8. Steffen ProhaskaAug 24, 2014
  9. 3/3 convert: Stream from fd to required clean filter instead of mmapSteffen Prohaska, Aug 21, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.