From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 22 Aug 2014 15:57:50 GMT
Subject: Re: [PATCH v3 2/3] Introduce GIT_MMAP_LIMIT to allow testing expected mmap size
Message-ID: <xmqqmwawpldt.fsf@gitster.dls.corp.google.com>
In-Reply-To: <0342479D-7C9F-42E6-9B79-745AEDE57EB5@zib.de>

Steffen Prohaska <prohaska@zib.de> writes:

>>> +	if (limit == -1) {
>>> +		const char *env = getenv("GIT_MMAP_LIMIT");
>>> +		limit = env ? atoi(env) * 1024 : 0;
>
> ... this should then be changed to atol(env), and ... 

In the real codepath (not debugging aid like this) we try to avoid
atoi/atol so that we can catch errors like feeding "123Q" and
parsing it as 123.