Re: mac test failure -- test 3301

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 11, 2014, 15:58 UTC
Message-ID: <xmqqmw7x7mpw.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CALKQrgexnrCy-P6yTZB+U0--5peaTys9KqB+KGKqbAuyLA=NqA@mail.gmail.com>

Johan Herland <johan@herland.net> writes:

> Ah, thanks!
>
> I thought that quoting command output was a good idea in general. Am I
> wrong, or is this just one exception to an otherwise good guideline?

It is not a good practice to blindly follow any guideline ;-).

When you anticipate that different platforms throw you unnecessary spaces around a single token you expect to see, not quoting is obviously the right thing. If you are unsure if the comamand gives you one or multiple tokens, you obviously risk the output getting split by not quoting.