git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: mac test failure -- test 3301

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Nov 11, 2014, 01:19 UTC
Message-ID
<CAPig+cRxCj82F5aak0Y+Ce_SvUETtQ5dwM1RtzjUUvwtJ=WPYw@mail.gmail.com>
In-Reply-To
<CAO2U3QhiWVvVKivBhE5R2xhjf8SPPtg6VSaQMxw7vbm_454jBQ@mail.gmail.com>
On Mon, Nov 10, 2014 at 7:17 PM, Michael Blume <blume.mike@gmail.com> wrote:
Show 15 quoted lines
> the commit modernizing test 3301
> (https://github.com/git/git/commit/fbe4f74865acfd) appears to break it
> on my mac
>
> $ ./t3301-notes.sh -v
> expecting success:
> MSG=b4 git notes add &&
> test_path_is_missing .git/NOTES_EDITMSG &&
> test "1" = "$(git ls-tree refs/notes/commits | wc -l)" &&
> test "b4" = "$(git notes show)" &&
> git show HEAD^ &&
> test_must_fail git notes show HEAD^
>
> b4
> not ok 8 - create notes

This and all other failures are due to the output of 'wc -l', which on Mac is "{whitespace}1" rather than just "1" as it is on other platforms. fbe4f748 added quotes around the $(... | wc -l) invocation which caused the whitespace to be retained. A minimum fix would be to drop the quotes surrounding $().

Previous: Michael BlumeNext: Johan Herland
Message 4 of 9 in “mac test failure -- test 3301”
  1. Michael BlumeNov 11, 2014
  2. Michael BlumeNov 11, 2014
  3. Michael BlumeNov 11, 2014
  4. Eric SunshineNov 11, 2014
  5. Johan HerlandNov 11, 2014
  6. Michael BlumeNov 11, 2014
  7. Jeff KingNov 11, 2014
  8. Johan HerlandNov 11, 2014
  9. Junio C HamanoNov 11, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.