Re: [PATCH 1/6] blame: remove obsolete comment

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 28, 2015, 17:35 UTC
Message-ID: <xmqqmvsulbly.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1451181092-26054-2-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

Show 5 quoted lines

> That "someday" in the comment happened two years later in
> b65982b (Optimize "diff-index --cached" using cache-tree - 2009-05-20)
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---

Thanks.

Show 19 quoted lines

>  builtin/blame.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/builtin/blame.c b/builtin/blame.c
> index 06484c2..9a0df92 100644
> --- a/builtin/blame.c
> +++ b/builtin/blame.c
> @@ -2379,11 +2379,6 @@ static struct commit *fake_working_tree_commit(struct diff_options *opt,
>  	ce->ce_mode = create_ce_mode(mode);
>  	add_cache_entry(ce, ADD_CACHE_OK_TO_ADD|ADD_CACHE_OK_TO_REPLACE);
>  
> -	/*
> -	 * We are not going to write this out, so this does not matter
> -	 * right now, but someday we might optimize diff-index --cached
> -	 * with cache-tree information.
> -	 */
>  	cache_tree_invalidate_path(&the_index, path);
>  
>  	return commit;