git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/6] blame: remove obsolete comment

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Dec 27, 2015, 01:51 UTC
Message-ID
<1451181092-26054-2-git-send-email-pclouds@gmail.com>
In-Reply-To
<1451181092-26054-1-git-send-email-pclouds@gmail.com>

That "someday" in the comment happened two years later in b65982b (Optimize "diff-index --cached" using cache-tree - 2009-05-20)

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 builtin/blame.c | 5 -----
 1 file changed, 5 deletions(-)
diff --git a/builtin/blame.c b/builtin/blame.c
index 06484c2..9a0df92 100644
--- a/builtin/blame.c
+++ b/builtin/blame.c
@@ -2379,11 +2379,6 @@ static struct commit *fake_working_tree_commit(struct diff_options *opt,
 	ce->ce_mode = create_ce_mode(mode);
 	add_cache_entry(ce, ADD_CACHE_OK_TO_ADD|ADD_CACHE_OK_TO_REPLACE);
 
-	/*
-	 * We are not going to write this out, so this does not matter
-	 * right now, but someday we might optimize diff-index --cached
-	 * with cache-tree information.
-	 */
 	cache_tree_invalidate_path(&the_index, path);
 
 	return commit;
-- 
2.3.0.rc1.137.g477eb31
Previous: Nguyễn Thái Ngọc DuyNext: Junio C Hamano
Message 2 of 15 in “nd/ita-cleanup updates”
  1. 0/6 nd/ita-cleanup updatesNguyễn Thái Ngọc Duy, Dec 27, 2015
  2. 1/6 blame: remove obsolete commentNguyễn Thái Ngọc Duy, Dec 27, 2015
  3. Junio C HamanoDec 28, 2015
  4. 2/6 Add and use convenient macro ce_intent_to_add()Nguyễn Thái Ngọc Duy, Dec 27, 2015
  5. Junio C HamanoDec 28, 2015
  6. 3/6 apply: fix adding new files on i-t-a entriesNguyễn Thái Ngọc Duy, Dec 27, 2015
  7. Junio C HamanoDec 28, 2015
  8. Duy NguyenDec 29, 2015
  9. Junio C HamanoDec 29, 2015
  10. 4/6 apply: make sure check_preimage() does not leave empty file on errorNguyễn Thái Ngọc Duy, Dec 27, 2015
  11. Junio C HamanoDec 28, 2015
  12. 5/6 checkout(-index): do not checkout i-t-a entriesNguyễn Thái Ngọc Duy, Dec 27, 2015
  13. Junio C HamanoDec 28, 2015
  14. 6/6 grep: make it clear i-t-a entries are ignoredNguyễn Thái Ngọc Duy, Dec 27, 2015
  15. Junio C HamanoDec 28, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.