Re: storing cover letter of a patch series?

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 8, 2016, 17:42 UTC
Message-ID: <xmqqmvknf986.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CACsJy8DhDMkmq-WCVHSMYVTTfEXNFUUzz5Cq9hQj_tGRUTj3ZA@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

> git-notes was mentioned in this thread back in 2015, but I think it's
> discarded because of the argument that's part of the cover letter was
> not meant to be kept permanently.

I do not think the reason why we didn't think the notes mechanism was a good match was mainly because the cover letter material was about a branch as a whole, which does not have a good counter-part in Git at the conceptual level. "A branch is just a moving pointer that points at one commit that happens to be at the tip" is not a perfect match to "I am holding these N patches to achieve X and I am constantly adding, rewinding and rebuilding". The notes mechanism gives an easy way to describe the former (i.e. annotate one commit, and let various commands to move that notes as you rewind and rebuild) but not the latter (i.e. "branch.description" configuration is the best match, but that is just a check-box feature and does not make any serious attempt to be part of a version-control system).

Show 6 quoted lines

> But I think we can still use it as a
> local/temporary place for cover letter instead of the empty commit at
> the topic's tip. It is a mark of the beginning of commit, it does not
> require rewriting history when you update the cover letter, and
> git-merge can be taught to pick it up when you're ready to set it in
> stone.

That depends on what you exactly mean by "the beginning of". Do you mean the first commit that is on the topic? Then that still requires you to move it around when the topic is rebuilt. If you mean the commit on the mainline the topic forks from, then of course that would not work, as you can fork multiple topics at the same commit.