Re: storing cover letter of a patch series?
- From
Philip Oakley <philipoakley@iee.org>
- Date
- Aug 16, 2016, 21:29 UTC
- Message-ID
- <A12D8350E1E24F12B530B6EBC9B4E321@PhilipOakley>
- In-Reply-To
- <CACsJy8DJmONcgQO37Xk+2cZb+Svx-bgwjrG1XrZQ4BYipownqw@mail.gmail.com>
From: "Duy Nguyen" <pclouds@gmail.com>
Show 23 quoted lines
> On Tue, Aug 16, 2016 at 12:26 PM, Jacob Keller <jacob.keller@gmail.com> > wrote: >>>> They can just add "squash! cover! <series>" commits for that ;-) Though >>>> more >>>> likely the advanced workflow would be used... We'll need both (more >>>> than >>>> one) options. >>> >>> Or even better, "git commit --reword $SHA1" brings up the editor with >>> commit message of $SHA1. Modify any way you want and it creates a new >>> empty, "reword!" commit that contains the diff between the old commit >>> message and the new one. "reword!" can be consumed by "rebase -i >>> --autosquash" without bringing up the editor again. I realize making >>> "git commit --reword" run multiple times would be tricky though... >> >> I was just thinking you write text and it gets appended to the text of >> the reworded commit, and when you squash them using rebase you get to >> finalize it like a normal squash? > > I think that's what Phillip meant by 'squash! cover!' though I wanted > to go further, I don't want an editor popping up at rebase time, > instead 'rebase' just update cover letter automatically for me. > --
Hi Duy, While we can have code that is auto merged, I don't think that I'd want to submit a cover letter that was simply auto merged. I'd want to refresh and re-personalise the text. As long as the flexibility in our cover letter inclusion is there.... -- Philip