Re: [PATCH 00/11] nd/worktree-move update

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 2, 2017, 20:21 UTC
Message-ID: <xmqqmve4s5r2.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <alpine.DEB.2.20.1702021330040.3496@virtualbox>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Also, the more important reply was Peff's reply that suggested that the
> proposed fix was incomplete, as it misses --unpack-unreachable:
> https://public-inbox.org/git/20160601160143.GA9219@sigill.intra.peff.net/

While I think that --unpack-unreachable thing is a symptom of the basic approach of patching things up at the wrong level, if you are hinting that fix to the issue that gc does not pay attention to various anchoring point in other worktrees is more important than adding new commands to "worktree", I fully agree with that.

We have a basic structure of "worktree" working well enough to allow adventurous folks to experiment (there is a reason why we keep calling it experimental). mv and other additions are primarily to make things _easier_ to use, but we shouldn't be encouraging its use to general public by making it easier for them to hurt themselves, if we know there still are sharp edges.

Thanks for bringing it up.