Re: [PATCH 00/11] nd/worktree-move update
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Feb 2, 2017, 11:22 UTC
- Message-ID
- <CACsJy8CBG_a_nX_syXKrdG2-ren=NO9CNxe6tm94FGnEo1HZLQ@mail.gmail.com>
- In-Reply-To
- <alpine.DEB.2.20.1702021136210.3496@virtualbox>
On Thu, Feb 2, 2017 at 5:37 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 33 quoted lines
> Hi Duy, > > On Thu, 2 Feb 2017, Duy Nguyen wrote: > >> On Thu, Feb 2, 2017 at 4:43 PM, Johannes Schindelin >> <Johannes.Schindelin@gmx.de> wrote: >> > >> > On Thu, 2 Feb 2017, Duy Nguyen wrote: >> > >> >> On Thu, Feb 2, 2017 at 4:16 PM, Johannes Schindelin >> >> <Johannes.Schindelin@gmx.de> wrote: >> >> > >> >> > On Thu, 2 Feb 2017, Nguyễn Thái Ngọc Duy wrote: >> >> > >> >> >> This squashes two changes from Johannes and Ramsay: [...] >> >> > >> >> > Sorry, I lost track of the worktree discussions... Could you remind >> >> > me which patch is supposed to fix my continuous reflog corruption? >> >> >> >> The corruption caused by git-gc? It's not fixed. All the changes in >> >> this series is shown here. >> > >> > Oh sorry, I meant to ask "and if it is not in this patch series, would you >> > mind pointing me at the patch series that has that fix?" >> >> You meant this one [1]? There is nothing substantial since then. >> >> [1] https://public-inbox.org/git/%3C20160601104519.16563-1-pclouds@gmail.com%3E/ > > I guess I mean that. > > Given that this results in real data loss, it is surprising that this has > not made it even into `pu` yet!
I could rebase and clean it up a bit if you need it, but I don't think it'll end up in 'pu' or anywhere near since Junio wanted a cleaner approach [1]. That means (as far as I can see) a lot more work around refs store and backend area before it's ready to handle "get refs from this worktree store" (or "get refs from every reachable stores").
[1] https://public-inbox.org/git/xmqqshwwzyee.fsf@gitster.mtv.corp.google.com/
-- Duy