Re: [PATCH v2 0/3] interpret-trailers: add --where, --if-exists, --if-missing

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 12, 2017, 23:02 UTC
Message-ID: <xmqqmv89z2be.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170712222116.7095-1-bonzini@gnu.org>

Paolo Bonzini <bonzini@gnu.org> writes:

Show 9 quoted lines

> From: Paolo Bonzini <pbonzini@redhat.com>
>
> These options are useful to experiment with "git interpret-trailers"
> without having to tinker with .gitconfig.  It can also be useful in the
> oddball case where you want a different placement for the trailer.
>
> Compared to "git -c", they are more easily discoverable, and also have
> slightly different behavior because they override all trailer.*
> configuration keys.

I think this is a very good idea (we shouldn't have started the command only with the configurations; we rather should have done this first and then added configuration after that).

Looking forward to reviewing them, but I am cutting a maint release now, so it may have to wait a bit.

Thanks.

Show 16 quoted lines

>
> Paolo
>
> v1->v2: support --no-* options, minor code fixes
>
> Paolo Bonzini (3):
>   trailers: create struct trailer_opts
>   trailers: export action enums and corresponding lookup functions
>   interpret-trailers: add options for actions
>
>  Documentation/git-interpret-trailers.txt |  16 +++++
>  builtin/interpret-trailers.c             |  44 ++++++++++---
>  t/t7513-interpret-trailers.sh            |  66 ++++++++++++++++++++
>  trailer.c                                | 102 ++++++++++++++++++++-----------
>  trailer.h                                |  35 ++++++++++-
>  5 files changed, 218 insertions(+), 45 deletions(-)