Re: [PATCH v2 0/3] interpret-trailers: add --where, --if-exists, --if-missing
- From
Paolo Bonzini <bonzini@gnu.org>
- Date
- Jul 12, 2017, 23:42 UTC
- Message-ID
- <d5e439c3-ba17-8efa-647d-eb64128064c8@gnu.org>
- In-Reply-To
- <xmqqmv89z2be.fsf@gitster.mtv.corp.google.com>
On 13/07/2017 01:02, Junio C Hamano wrote:
Show 15 quoted lines
> Paolo Bonzini <bonzini@gnu.org> writes: > >> From: Paolo Bonzini <pbonzini@redhat.com> >> >> These options are useful to experiment with "git interpret-trailers" >> without having to tinker with .gitconfig. It can also be useful in the >> oddball case where you want a different placement for the trailer. >> >> Compared to "git -c", they are more easily discoverable, and also have >> slightly different behavior because they override all trailer.* >> configuration keys. > > I think this is a very good idea (we shouldn't have started the > command only with the configurations; we rather should have done > this first and then added configuration after that).
Actually we can do better: we can have --where only refer to *subsequent* --trailer options. This will require more refactoring (probably making a new struct that can be passed to process_trailers), but the first two patches should be the same.
I'll have time for this only after vacation (so at the end of July), and it's backwards-incompatible with this series. Reviews are welcome anyway. :)
Thanks for encouraging me. It's always a pleasure when I can scratch my git itches!
Paolo
Show 22 quoted lines
> Looking forward to reviewing them, but I am cutting a maint release > now, so it may have to wait a bit. > > Thanks. > >> >> Paolo >> >> v1->v2: support --no-* options, minor code fixes >> >> Paolo Bonzini (3): >> trailers: create struct trailer_opts >> trailers: export action enums and corresponding lookup functions >> interpret-trailers: add options for actions >> >> Documentation/git-interpret-trailers.txt | 16 +++++ >> builtin/interpret-trailers.c | 44 ++++++++++--- >> t/t7513-interpret-trailers.sh | 66 ++++++++++++++++++++ >> trailer.c | 102 ++++++++++++++++++++----------- >> trailer.h | 35 ++++++++++- >> 5 files changed, 218 insertions(+), 45 deletions(-) >