Re: [PATCH 2/2] builtin/blame: highlight recently changed lines

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 14, 2018, 17:37 UTC
Message-ID: <xmqqmuvx46cy.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <737e4f2e-9896-0119-2c43-655ac29fe018@web.de>

René Scharfe <l.s.r@web.de> writes:

Show 8 quoted lines

>
> This adds a minor memory leak; fix below.
>
> -- >8 --
> Subject: [PATCH] blame: release string_list after use in parse_color_fields()
>
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---

Thanks.  Will apply.

Show 15 quoted lines

>  builtin/blame.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/builtin/blame.c b/builtin/blame.c
> index 4202584f97..3295718841 100644
> --- a/builtin/blame.c
> +++ b/builtin/blame.c
> @@ -411,6 +411,7 @@ static void parse_color_fields(const char *s)
>  		die (_("must end with a color"));
>  
>  	colorfield[colorfield_nr].hop = TIME_MAX;
> +	string_list_clear(&l, 0);
>  }
>  
>  static void setup_default_color_by_age(void)