Re: [PATCH 2/2] builtin/blame: highlight recently changed lines

From: Stefan Beller <sbeller@google.com>
Date: Apr 17, 2018, 19:31 UTC
Message-ID: <CAGZ79kb+MEJswk9NU3ktr9gAY7XVdCYS-w=e-Qmmp8knSNsHTg@mail.gmail.com>
In-Reply-To: <xmqqbmeiv7c2.fsf@gitster-ct.c.googlers.com>

On Mon, Apr 16, 2018 at 8:29 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 9 quoted lines

> It seems that this
>
> $ git -c color.blame.repeatedlines=cyan blame --heated-lines builtin/blame.c
>
> refuses to run.
>
> Would it work if the configuration is in .git/config instead, or
> would it forever disable --heated-lines once somebody choses to use
> --color-lines feature by default by configuring it in?

That is the unfortunate part of this series, I have not figured out how to treat these two options at the same time.

One could take the approach to check the config first and see if there are conflicts and then overlay it with the command line options (and resolve conflicts there, but CLI taking precedence over config).

Or we'd need to introduce another config blame.coloring={none, repeatedlines, highlightrecent} which breaks the tie.

Thanks, Stefan