Re: [PATCH v2 0/6] git-submodule.sh: convert part of cmd_update to C
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 17, 2018, 18:39 UTC
- Message-ID
- <xmqqmuupogei.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20180717002654.120375-1-sbeller@google.com>
Stefan Beller <sbeller@google.com> writes:
Show 25 quoted lines
>> v2: >> addressed review comments, renaming the struct, improving the commit message. >> >> v1: >> https://public-inbox.org/git/20180712194754.71979-1-sbeller@google.com/ >> I thought about writing it all in one go, but the series got too large, >> so let's chew one bite at a time. >> >> Thanks, >> Stefan >> >> Stefan Beller (6): >> git-submodule.sh: align error reporting for update mode to use path >> git-submodule.sh: rename unused variables >> builtin/submodule--helper: factor out submodule updating >> builtin/submodule--helper: store update_clone information in a struct >> builtin/submodule--helper: factor out method to update a single >> submodule >> submodule--helper: introduce new update-module-mode helper >> >> builtin/submodule--helper.c | 152 ++++++++++++++++++++++++++++-------- >> git-submodule.sh | 22 +----- >> 2 files changed, 122 insertions(+), 52 deletions(-) >> >> --
A tangent.
Because this "-- " is a conventional signature separator, MUAs like Emacs message-mode seems to omit everything below it from the quote while responding, making it cumbersome to comment on the tbdiff.
Something to think about if somebody is contemplating on adding more to format-patch's cover letter.
Show 11 quoted lines
>> 2.18.0.203.gfac676dfb9-goog >> >> 1: d4e1ec45740 ! 1: bbc8697a8ca git-submodule.sh: align error reporting for update mode to use path >> @@ -6,7 +6,6 @@ >> on its path, so let's do that for invalid update modes, too. >> >> Signed-off-by: Stefan Beller <sbeller@google.com> >> - Signed-off-by: Junio C Hamano <gitster@pobox.com> >> >> diff --git a/git-submodule.sh b/git-submodule.sh >> --- a/git-submodule.sh
This is quite unfortunate. I wonder if it is easy to tell range-diff that certain differences in the log message are to be ignored so that we can show that the first patch is unchanged in a case like this. This series has 4 really changed ones with 2 otherwise unchanged ones shown all as changed, which is not too bad, but for a series like sb/diff-colro-move-more reroll that has 9 patches, out of only two have real updated patches, showing otherwise unchanged 7 as changed like this hunk does would make the cover letter useless. It is a shame that adding range-diff to the cover does have so much potential.