git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/6] git-submodule.sh: align error reporting for update mode to use path

From
Stefan Beller <sbeller@google.com>
Date
Jul 17, 2018, 00:26 UTC
Message-ID
<20180717002654.120375-2-sbeller@google.com>
In-Reply-To
<20180717002654.120375-1-sbeller@google.com>

All other error messages in cmd_update are reporting the submodule based on its path, so let's do that for invalid update modes, too.

Signed-off-by: Stefan Beller <sbeller@google.com>
---
 git-submodule.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index 5f9d9f6ea37..8a611865397 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -627,7 +627,7 @@ cmd_update()
 				must_die_on_failure=yes
 				;;
 			*)
-				die "$(eval_gettext "Invalid update mode '$update_module' for submodule '$name'")"
+				die "$(eval_gettext "Invalid update mode '$update_module' for submodule path '$path'")"
 			esac
 
 			if (sanitize_submodule_env; cd "$sm_path" && $command "$sha1")
-- 
2.18.0.203.gfac676dfb9-goog
Previous: Stefan BellerNext: Stefan Beller
Message 2 of 20 in “git-submodule.sh: convert part of cmd_update to C”
  1. 0/6 git-submodule.sh: convert part of cmd_update to CStefan Beller, Jul 17, 2018
  2. 1/6 git-submodule.sh: align error reporting for update mode to use pathStefan Beller, Jul 17, 2018
  3. 2/6 git-submodule.sh: rename unused variablesStefan Beller, Jul 17, 2018
  4. 3/6 builtin/submodule--helper: factor out submodule updatingStefan Beller, Jul 17, 2018
  5. 4/6 builtin/submodule--helper: store update_clone information in a structStefan Beller, Jul 17, 2018
  6. 5/6 builtin/submodule--helper: factor out method to update a single submoduleStefan Beller, Jul 17, 2018
  7. 6/6 submodule--helper: introduce new update-module-mode helperStefan Beller, Jul 17, 2018
  8. SZEDER GáborJul 17, 2018
  9. Junio C HamanoJul 17, 2018
  10. Junio C HamanoJul 17, 2018
  11. Stefan BellerJul 17, 2018
  12. Eric SunshineJul 17, 2018
  13. Stefan BellerJul 18, 2018
  14. Eric SunshineJul 18, 2018
  15. Junio C HamanoJul 18, 2018
  16. Junio C HamanoJul 17, 2018
  17. Stefan BellerJul 17, 2018
  18. Junio C HamanoJul 17, 2018
  19. Johannes SchindelinJul 26, 2018
  20. Stefan BellerJul 26, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.