Re: [PATCH] log: add %S option (like --source) to log --format

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 2, 2019, 19:33 UTC
Message-ID: <xmqqmuoikg6x.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20181231045335.12883-1-issac.trotts@gmail.com>

issac.trotts@gmail.com writes:

> From: Issac Trotts <issac.trotts@gmail.com>

I think you want to have

	From: Issac Trotts <issactrotts@google.com>

instead, so that the authorship actually matches your sign-off.

> -	if (source) {
> +	if (source || (rev->pretty_given && (rev->commit_format == CMIT_FMT_USERFORMAT) && w.source)) {

I am not sure why the above is not simply

	if (source || w.source) {

but needs to check pretty-given etc.  Care to explain why?

Thanks.