Re: [PATCH] log: add %S option (like --source) to log --format

From: Issac Trotts <issac.trotts@gmail.com>
Date: Jan 8, 2019, 13:14 UTC
Message-ID: <CANdyxMxZGdOLmmXNy+MF4UJWuZFvUABuMq0JP+y-CXPE323WSQ@mail.gmail.com>
In-Reply-To: <xmqqmuoikg6x.fsf@gitster-ct.c.googlers.com>

On Thu, Jan 3, 2019 at 6:33 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

>
> issac.trotts@gmail.com writes:
>
> > From: Issac Trotts <issac.trotts@gmail.com>
>
> I think you want to have
>
>         From: Issac Trotts <issactrotts@google.com>
>
> instead, so that the authorship actually matches your sign-off.

Makes sense. I'll do that.

Show 9 quoted lines

>
> > -     if (source) {
> > +     if (source || (rev->pretty_given && (rev->commit_format == CMIT_FMT_USERFORMAT) && w.source)) {
>
> I am not sure why the above is not simply
>
>         if (source || w.source) {
>
> but needs to check pretty-given etc.  Care to explain why?

Good idea. Your simplified version passes all the tests.